Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40247: Make VM Diagnostics tab's help icons smaller #1867

Merged

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 5, 2024

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40247

Make the icons smaller to look better, also delete non-existent title-help-text-icon class from HelpTextIcon components in more places of the codebase.

🎥 Screenshots

Before:
"?" icons too big in VM Diagnostics tab:
cyan_before

After:
"?" icons smaller, nicer:
cyan_after

Make the icons smaller to look better, also delete non-existent
"title-help-text-icon" class from HelpTextIcon components in more places
of the codebase.

Fixes https://issues.redhat.com/browse/CNV-40247
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 5, 2024

@hstastna: This pull request references CNV-40247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40247

Make the icons smaller to look better, also delete non-existent title-help-text-icon class from HelpTextIcon components in more places of the codebase.

🎥 Screenshots

Before:
"?" icons too big in VM Diagnostics tab:
cyan_before

After:
"?" icons smaller, nicer:
cyan_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan April 5, 2024 14:37
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 5, 2024
@hstastna
Copy link
Author

hstastna commented Apr 5, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@metalice
Copy link
Member

metalice commented Apr 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 5, 2024
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7298f33 into kubevirt-ui:main Apr 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants