Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40200: Use "Clone" submit button for VM cloning instead of "Create" #1871

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 8, 2024

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40200

Display Clone submit button text in Clone VirtualMachine modal window instead of Create.
Keep displaying Create submit button text for cloning VM snapshots.

🎥 Demo

Before:
Create button text in the modal:

clone_before.mp4

After:
Clone button text:

clone_after.mp4

Display "Clone" for submit button text in "Clone VirtualMachine" modal
window instead of "Create". Keep displaying "Create" submit button text
for cloning VM snapshots.

Fixes https://issues.redhat.com/browse/CNV-40200
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 8, 2024

@hstastna: This pull request references CNV-40200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40200

Display Clone submit button text in Clone VirtualMachine modal window instead of Create.
Keep displaying Create submit button text for cloning VM snapshots.

🎥 Demo

Before:
Create button text in the modal:

clone_before.mp4

After:
Clone button text:

clone_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and metalice April 8, 2024 12:05
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 8, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 8, 2024

@hstastna: This pull request references CNV-40200 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40200

Display Clone submit button text in Clone VirtualMachine modal window instead of Create.
Keep displaying Create submit button text for cloning VM snapshots.

🎥 Demo

Before:
Create button text in the modal:

clone_before.mp4

After:
Clone button text:

clone_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna
Copy link
Author

hstastna commented Apr 8, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@hstastna
Copy link
Author

hstastna commented Apr 8, 2024

/retest

@hstastna
Copy link
Author

hstastna commented Apr 9, 2024

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@pcbailey
Copy link
Member

pcbailey commented Apr 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 9, 2024
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hstastna
Copy link
Author

hstastna commented Apr 9, 2024

/retest

6 similar comments
@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit a9ee37f into kubevirt-ui:main Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants