-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-40200: Use "Clone" submit button for VM cloning instead of "Create" #1871
CNV-40200: Use "Clone" submit button for VM cloning instead of "Create" #1871
Conversation
Display "Clone" for submit button text in "Clone VirtualMachine" modal window instead of "Create". Keep displaying "Create" submit button text for cloning VM snapshots. Fixes https://issues.redhat.com/browse/CNV-40200
@hstastna: This pull request references CNV-40200 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@hstastna: This pull request references CNV-40200 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
/retest |
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
6 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
/retest |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-40200
Display Clone submit button text in Clone VirtualMachine modal window instead of Create.
Keep displaying Create submit button text for cloning VM snapshots.
🎥 Demo
Before:
Create button text in the modal:
clone_before.mp4
After:
Clone button text:
clone_after.mp4