Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40196: PVC is not found in "Bootable volumes" -> Add volume modal #1875

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 9, 2024

📝 Description

When the InlineFilter component starts with an empty option list and then it populates based on other value, the list fails to initialize properly.
Also when searching in the search input and selecting an option, re-opening the same dropdown is still fixed to the search options even when the search input is cleared.

🎥 Demo

Before:
pvc-list
vs-list

After:
pvc-list-after
vs-list-after

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 9, 2024

@avivtur: This pull request references CNV-40196 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

When the InlineFilter component starts with an empty option list and then it populates based on other value, the list fails to initialize properly.
Also when searching in the search input and selecting an option, re-opening the same dropdown is still fixed to the search options even when the search input is cleared.

🎥 Demo

Before:
pvc-list
vs-list

After:
pvc-list-after
vs-list-after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 9, 2024
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@metalice
Copy link
Member

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/retet

@metalice
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit c856c4a into kubevirt-ui:main Apr 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants