Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-39531: Make Getting started card expandable #1877

Merged

Conversation

hstastna
Copy link

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-39531

Display Getting started resources expandable section in the Virtualization Overview expanded by default - same as in the console.

🎥 Demo

Before:
Getting started card not expanded when entering Virtualization Overview for the 1st time:

exp_before.mp4

After:
Getting started card expanded by default:

exp_after.mp4

Display "Getting started resources" expandable section in the
Virtualization overview expanded by default - same as in the console.

Fixes https://issues.redhat.com/browse/CNV-39531
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2024

@hstastna: This pull request references CNV-39531 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-39531

Display Getting started resources expandable section in the Virtualization Overview expanded by default - same as in the console.

🎥 Demo

Before:
Getting started card not expanded when entering Virtualization Overview for the 1st time:

exp_before.mp4

After:
Getting started card expanded by default:

exp_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 10, 2024
@hstastna
Copy link
Author

hstastna commented Apr 10, 2024

@avivtur @pcbailey @upalatucci @metalice please review

@hstastna
Copy link
Author

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hstastna
Copy link
Author

/retest

6 similar comments
@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@pcbailey
Copy link
Member

/retest

@hstastna
Copy link
Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 3bfc680 into kubevirt-ui:main Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants