Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV-40059: Align VMs and Templates lists empty pages with the new format #1878

Merged
merged 1 commit into from
Apr 21, 2024
Merged

CNV-40059: Align VMs and Templates lists empty pages with the new format #1878

merged 1 commit into from
Apr 21, 2024

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 10, 2024 •
edited
Loading

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

Additionally, in case when there are item in the list but after filtering we get zero results, prevent displaying unnecessary pagination showing zero results and pages - for VMs list.

🎥 Screenshots

Before:
VMs list empty page:
vm_before
VM Templates list empty page:
vm_templates_before
VMs list page with zero results after filtering:
vv_before

After:
VMs list empty page:
vm_after
VM Templates list empty page:
templates_afterr
VMs list page with zero results after filtering:
vv_after

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E/

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
temp_before

After:
VMs list page:
vm_after
VM Templates list page:
temp_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 10, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
temp_before

After:
VMs list page:
vm_after
VM Templates list page:
temp_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna
Copy link
Author

@avivtur @pcbailey @upalatucci @metalice please review

@hstastna
Copy link
Author

/retest

1 similar comment
@hstastna
Copy link
Author

/retest

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates was updated, in this PR.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
temp_before

After:
VMs list page:
vm_after
VM Templates list page:
temp_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 10, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
temp_before

After:
VMs list page:
vm_after
VM Templates list page:
temp_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna
Copy link
Author

/retest

1 similar comment
@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna
Copy link
Author

/retest

@hstastna hstastna requested a review from metalice April 11, 2024 17:02
@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from ba9c357 to 13187d0 Compare April 11, 2024 17:07
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 11, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
vm_templates_before

After:
VMs list page:
vm_after
VM Templates list page:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 11, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
vm_templates_before

After:
VMs list page:
vm_after
VM Templates list page:
templates_afterr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 11, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
vm_templates_before

After:
VMs list page:
vm_after
VM Templates list page:
templates_afterr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from 13187d0 to bd77562 Compare April 11, 2024 18:26
@hstastna
Copy link
Author

/retest

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from bd77562 to 9b3b10f Compare April 12, 2024 13:03
@hstastna
Copy link
Author

/retest

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch 2 times, most recently from 722c535 to aa87f61 Compare April 16, 2024 07:56
@hstastna
Copy link
Author

@metalice PTAL about the changes I've done (a separate commit just for review purpose, later I can squash, of course). Thanks!

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from ba33411 to ce9c910 Compare April 18, 2024 12:57
@hstastna hstastna requested a review from metalice April 18, 2024 20:02
@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from ce9c910 to fa9c021 Compare April 19, 2024 08:48
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

Additionally, in case when there are item in the list but after filtering we get zero results, hide unnecessary pagination showing zero results and pages - for VMs list.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
vm_templates_before

After:
VMs list page:
vm_after
VM Templates list page:
templates_afterr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

Additionally, in case when there are item in the list but after filtering we get zero results, prevent displaying unnecessary pagination showing zero results and pages - for VMs list.

🎥 Screenshots

Before:
VMs list page:
vm_before
VM Templates list page:
vm_templates_before

After:
VMs list page:
vm_after
VM Templates list page:
templates_afterr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from fa9c021 to ae3720f Compare April 19, 2024 15:24
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

Additionally, in case when there are item in the list but after filtering we get zero results, prevent displaying unnecessary pagination showing zero results and pages - for VMs list.

🎥 Screenshots

Before:
VMs list empty page:
vm_before
VM Templates list empty page:
vm_templates_before
VMs list empty page with zero results after filtering:
vv_before

After:
VMs list empty page:
vm_after
VM Templates list empty page:
templates_afterr
VMs list empty page with zero results after filtering:
vv_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024 •
edited by openshift-ci bot
Loading

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Align VMs and Templates lists empty pages with the new format for more consistent look across the UI, add the appropriate icons and text, links, remove unnecessary create buttons, filtering and pagination. Also the link to get to know more about creating VMs from Templates from the doc was updated, in this PR. I've made sure that the lists look as expected in case of not being empty, too.

Additionally, in case when there are item in the list but after filtering we get zero results, prevent displaying unnecessary pagination showing zero results and pages - for VMs list.

🎥 Screenshots

Before:
VMs list empty page:
vm_before
VM Templates list empty page:
vm_templates_before
VMs list page with zero results after filtering:
vv_before

After:
VMs list empty page:
vm_after
VM Templates list empty page:
templates_afterr
VMs list page with zero results after filtering:
vv_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from ae3720f to 9932dda Compare April 19, 2024 16:19
CNV-40059: Align VMs and Templates lists empty pages with the new format
6aadd8a 
Also prevent displaying empty state pages if there are some (unfiltered)
data in the list page. Display simplified "No <resource name> found"
message in case filtering shows zero results.

Additionally, in case filtering shows zero results, prevent displaying
unnecessary pagination showing zeros - for VMs list.

Fixes https://issues.redhat.com/browse/CNV-40059
@hstastna hstastna force-pushed the Align_empty_states_VMs_Templates branch from 9932dda to 6aadd8a Compare April 19, 2024 16:23
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 929f71c into kubevirt-ui:main Apr 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey Awaiting requested review from pcbailey

@metalice metalice Awaiting requested review from metalice

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hstastna @openshift-ci-robot @metalice