Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40059: Update Checkups lists for 0 results after filtering #1890

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 19, 2024

📝 Description

This is another PR belonging to the epic:
https://issues.redhat.com/browse/CNV-40059

Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it. Also display missing pagination.

🎥 Screenshots

Before:
Network latency checkups list:
c_before
Storage checkups list:
cc_before

After:
Network latency checkups list:
ccc_after
Storage checkups list:
cccc_after

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 19, 2024
@hstastna
Copy link
Author

@avivtur @pcbailey @upalatucci @metalice please review

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This is another PR belonging to the epic:
https://issues.redhat.com/browse/CNV-40059

Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it. Also display missing pagination.

🎥 Screenshots

Before:
Network latency checkups list:
ch_before
Storage checkups list:
ss_before

After:
Network latency checkups list:
ch_after
Storage checkups list:
ss_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This is another PR belonging to the epic:
https://issues.redhat.com/browse/CNV-40059

Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it. Also display missing pagination.

🎥 Screenshots

Before:
Network latency checkups list:
c_before
Storage checkups list:
cc_before

After:
Network latency checkups list:
c_after
Storage checkups list:
cc_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna hstastna force-pushed the Align_empty_states_Checkups_lists branch from 7691b5c to 1bb81ec Compare April 19, 2024 15:12
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 19, 2024

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This is another PR belonging to the epic:
https://issues.redhat.com/browse/CNV-40059

Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it. Also display missing pagination.

🎥 Screenshots

Before:
Network latency checkups list:
c_before
Storage checkups list:
cc_before

After:
Network latency checkups list:
ccc_after
Storage checkups list:
cccc_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Display Network latency and storage checkups lists correctly after
getting zero results from the list filtering. Update the message that is
displayed in this scenario by adding the resource name to it. Also
display missing pagination.

Fixes https://issues.redhat.com/browse/CNV-40059
@hstastna hstastna force-pushed the Align_empty_states_Checkups_lists branch from 1bb81ec to 995556e Compare April 19, 2024 15:47
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 21, 2024
Copy link
Contributor

openshift-ci bot commented Apr 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c653b88 into kubevirt-ui:main Apr 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants