-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-40059: Update Checkups lists for 0 results after filtering #1890
CNV-40059: Update Checkups lists for 0 results after filtering #1890
Conversation
@avivtur @pcbailey @upalatucci @metalice please review |
@hstastna: This pull request references CNV-40059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@hstastna: This pull request references CNV-40059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7691b5c
to
1bb81ec
Compare
@hstastna: This pull request references CNV-40059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it. Also display missing pagination. Fixes https://issues.redhat.com/browse/CNV-40059
1bb81ec
to
995556e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This is another PR belonging to the epic:
https://issues.redhat.com/browse/CNV-40059
Display Network latency and storage checkups lists correctly after getting zero results from the list filtering. Update the message that is displayed in this scenario by adding the resource name to it.
Also display missing pagination.🎥 Screenshots
Before:
Network latency checkups list:
Storage checkups list:
After:
Network latency checkups list:
Storage checkups list: