Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-39030: preference link leads 404 blink page #1894

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 21, 2024

📝 Description

Preference link leads to 404 page for a second (missing namespace)
Instance type is not loading on create VM from snapshot.
Adding explanatory text for why linking ControllerReviosion clones to IT and Pref

🎥 Demo

After:

it-appear-create-vm-from-snapshot
it-appear-create-vm-from-snapshot3
it-appear-create-vm-from-snapshot2

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@avivtur: This pull request references CNV-39030 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

preference link leads to 404 page for a second (missing namespace)
instance type is not loading on create VM from snapshot.

🎥 Demo

After:

it-appear-create-vm-from-snapshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 21, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@avivtur: This pull request references CNV-39030 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

preference link leads to 404 page for a second (missing namespace)
instance type is not loading on create VM from snapshot.

🎥 Demo

After:

it-appear-create-vm-from-snapshot
it-appear-create-vm-from-snapshot3
it-appear-create-vm-from-snapshot2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@avivtur: This pull request references CNV-39030 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Preference link leads to 404 page for a second (missing namespace)
Instance type is not loading on create VM from snapshot.
Adding explanatory text for why linking ControllerReviosion clones to IT and Pref

🎥 Demo

After:

it-appear-create-vm-from-snapshot
it-appear-create-vm-from-snapshot3
it-appear-create-vm-from-snapshot2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit edb1c1d into kubevirt-ui:main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants