-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-40059: Align VirtualMachinePreferences empty page with new format #1895
CNV-40059: Align VirtualMachinePreferences empty page with new format #1895
Conversation
@hstastna: This pull request references CNV-40059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @pcbailey @upalatucci @metalice please review |
@hstastna: This pull request references CNV-40059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
634d5e8
to
6ecae59
Compare
Update VirtualMachinePreferences list (User provided) empty state page to look more consistent within the UI. Hide unnecessary filtering, pagination and also Create button in the upper right corner of the page. Additionally, in case there's some data and filtering shows zero results, prevent displaying unnecessary pagination. Fixes https://issues.redhat.com/browse/CNV-40059
6ecae59
to
4462814
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059
Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E
Update VirtualMachinePreferences list (User provided tab) empty state page to look more consistent within the UI. Hide unnecessary filtering, pagination and also Create button in the upper right corner of the page.
Additionally, in case there's some data and filtering shows zero results, prevent displaying unnecessary pagination.
Additionally, add little refactoring - use new useUserPreferences hook to get the related data in
UserPreferenceList
andPreferencePage
components.🎥 Screenshots
Before:
VirtualMachinePreferences empty state page:
VirtualMachinePreferences (non empty) list page with zero results after filtering:
After:
VirtualMachinePreferences empty state page:
VirtualMachinePreferences (non empty) list page with zero results after filtering: