Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40059: Align VirtualMachinePreferences empty page with new format #1895

Conversation

hstastna
Copy link

@hstastna hstastna commented Apr 21, 2024

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Update VirtualMachinePreferences list (User provided tab) empty state page to look more consistent within the UI. Hide unnecessary filtering, pagination and also Create button in the upper right corner of the page.

Additionally, in case there's some data and filtering shows zero results, prevent displaying unnecessary pagination.

Additionally, add little refactoring - use new useUserPreferences hook to get the related data in UserPreferenceList and PreferencePage components.

🎥 Screenshots

Before:
VirtualMachinePreferences empty state page:
p_before
VirtualMachinePreferences (non empty) list page with zero results after filtering:
f_before

After:
VirtualMachinePreferences empty state page:
p_after
VirtualMachinePreferences (non empty) list page with zero results after filtering:
f_after

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Update VirtualMachinePreferences list (User provided tab) empty state page to look more consistent within the UI. Hide unnecessary filtering, pagination and also Create button in the upper right corner of the page.

Additionally, in case there's some data and filtering shows zero results, prevent displaying unnecessary pagination.

Additionally, add little refactoring - use new useUserPreferences hook to get the related data in UserPreferenceList and PreferencePage components.

🎥 Screenshots

Before:
VirtualMachinePreferences empty state page:
p_before
VirtualMachinePreferences (non empty) list page with zero results after filtering:
f_before

After:
VirtualMachinePreferences empty state page:
p_after
VirtualMachinePreferences (non empty) list page with zero results after filtering:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 21, 2024
@hstastna
Copy link
Author

@avivtur @pcbailey @upalatucci @metalice please review

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@hstastna: This pull request references CNV-40059 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR is one of the PRs related to:
https://issues.redhat.com/browse/CNV-40059

Design doc:
https://docs.google.com/document/d/1q1J7QJPbklWNV02hqBIIi6uNwHKaipUFZLA3RJF5A9E

Update VirtualMachinePreferences list (User provided tab) empty state page to look more consistent within the UI. Hide unnecessary filtering, pagination and also Create button in the upper right corner of the page.

Additionally, in case there's some data and filtering shows zero results, prevent displaying unnecessary pagination.

Additionally, add little refactoring - use new useUserPreferences hook to get the related data in UserPreferenceList and PreferencePage components.

🎥 Screenshots

Before:
VirtualMachinePreferences empty state page:
p_before
VirtualMachinePreferences (non empty) list page with zero results after filtering:
f_before

After:
VirtualMachinePreferences empty state page:
p_after
VirtualMachinePreferences (non empty) list page with zero results after filtering:
f_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 22, 2024
@hstastna hstastna force-pushed the Align_empty_states_UserPreferences branch from 634d5e8 to 6ecae59 Compare April 22, 2024 14:34
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Apr 22, 2024
Update VirtualMachinePreferences list (User provided) empty state page
to look more consistent within the UI. Hide unnecessary filtering,
pagination and also Create button in the upper right corner of the page.

Additionally, in case there's some data and filtering shows zero
results, prevent displaying unnecessary pagination.

Fixes https://issues.redhat.com/browse/CNV-40059
@hstastna hstastna force-pushed the Align_empty_states_UserPreferences branch from 6ecae59 to 4462814 Compare April 22, 2024 15:56
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hstastna,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b6dfe65 into kubevirt-ui:main Apr 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants