Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41084: Vm conditions link #1902

Merged

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Apr 29, 2024

📝 Description

Remove href property that create the link behavior.

Remove tests for VM status condition. Why having snapshot tests if they were not able to detect this simple error? NO sense those tests

Screenshot from 2024-04-29 16-11-06

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 29, 2024

@upalatucci: This pull request references CNV-41084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Remove href property that create the link behavior.

Screenshot from 2024-04-29 16-11-06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and yaacov April 29, 2024 14:13
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 29, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 29, 2024

@upalatucci: This pull request references CNV-41084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Remove href property that create the link behavior.

Remove tests for VM status condition. Why having snapshot tests if they were not able to detect this simple error? NO sense those errors

Screenshot from 2024-04-29 16-11-06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 29, 2024

@upalatucci: This pull request references CNV-41084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Remove href property that create the link behavior.

Remove tests for VM status condition. Why having snapshot tests if they were not able to detect this simple error? NO sense those tests

Screenshot from 2024-04-29 16-11-06

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b24faaa into kubevirt-ui:main May 2, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants