CNV-41522: Fix customize IT #1922
Conversation
|
@metalice: This pull request references CNV-41522 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-41522-fix-customize-it
branch
from
f576d28
to
56a95a9
Compare
| @@ -28,6 +28,7 @@ import './CustomizeITVMFooter.scss'; | |||
| const CustomizeITVMFooter: FC = () => { | |||
| const { t } = useKubevirtTranslation(); | |||
| const navigate = useNavigate(); | |||
| const [activeNamespace] = useActiveNamespace(); | |||
There was a problem hiding this comment.
Can this page be rendered on 'all-namespaces' ? In this case activeNamespace will be ALL_NAMESPACES_SESSION_KEY
There was a problem hiding this comment.
should be fine, as this is only for the cancel button, but a wider check and adjustment will be followed so changes will be made again
| @@ -37,12 +37,14 @@ export const updateCustomizeInstanceType: UpdateCustomizeInstanceType = ( | |||
| updateValues, | |||
| ): V1VirtualMachine => { | |||
| let vm = vmSignal.value; | |||
|
|
|||
| const { createModal } = useModal(); | ||
|
|
||
| const vm = vmSignal.value || vmContext; |
There was a problem hiding this comment.
Is this a temporary solution or will we always use context as a fallback? If it's not temporary, what's the value in having two store solutions?
There was a problem hiding this comment.
in the end i would like to remove all use of context and stay only with signals so its temp until a wider refactor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e2e4e2b
into
kubevirt-ui:main
📝 Description
Fix the flow of customize IT
Edit disk
Edit nic
Cancel redirect
Adding SSH
Boot managment
🎥 Demo