Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-39727: fix pagination on bootablevolume selection #1930

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

When selecting a bootable volume in instancetype VM creation, the list pagination gets on the first page.
This because we are using the unsorted list to calculate in which page we should be.

Why we do that? Because user can select the bootablevolume from a modal clicking on 'Show all' bootable volume. And clicking on 'select' should change the list page into the current selection page.

So we need a sorted array for identify the right page in which the selection is and a sortedPaginated array to show just the paginated volumes that we want in the list

Another fix:

TabModal expect a submit method that return a promise. So just return a promise.resolve instead of changing the type.
Just changing the type result into an infinite button loading in the modal .

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 8, 2024

@upalatucci: This pull request references CNV-39727 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

When selecting a bootable volume in instancetype VM creation, the list pagination gets on the first page.
This because we are using the unsorted list to calculate in which page we should be.

Why we do that? Because user can select the bootablevolume from a modal clicking on 'Show all' bootable volume. And clicking on 'select' should change the list page into the current selection page.

So we need a sorted array for identify the right page in which the selection is and a sortedPaginated array to show just the paginated volumes that we want in the list

Another fix:

TabModal expect a submit method that return a promise. So just return a promise.resolve instead of changing the type.
Just changing the type result into an infinite button loading in the modal .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan May 8, 2024 08:22
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 8, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member Author

/retest

2 similar comments
@metalice
Copy link
Member

metalice commented May 9, 2024

/retest

@upalatucci
Copy link
Member Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 76272dd into kubevirt-ui:main May 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants