Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-37597: Fix i18n in pre-commit #1932

Conversation

metalice
Copy link
Member

@metalice metalice commented May 8, 2024

📝 Description

Fix the run and commit of the i18n translation file in pre-commit script.

🎥 Demo

no visual changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 8, 2024

@metalice: This pull request references CNV-37597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fix the run and commit of the i18n translation file in pre-commit script.

🎥 Demo

no visual changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from vojtechszocs and yaacov May 8, 2024 09:14
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 8, 2024
@metalice
Copy link
Member Author

metalice commented May 8, 2024

/retest

@metalice metalice requested review from upalatucci and removed request for yaacov May 8, 2024 13:40
@pcbailey
Copy link
Member

pcbailey commented May 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1be6c2a into kubevirt-ui:main May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants