Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41579: Removed featureGate fo memoryOverCommit #1934

Conversation

metalice
Copy link
Member

@metalice metalice commented May 8, 2024

📝 Description

MemoryOverCommit is no longer a featureGate, so I am fixing the logic not to look at the feature gate anymore.

🎥 Demo

No visual changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 8, 2024

@metalice: This pull request references CNV-41579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

MemoryOverCommit is no longer a featureGate, so I am fixing the logic not to look at the feature gate anymore.

🎥 Demo

No visual changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and hstastna May 8, 2024 13:37
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 8, 2024
@pcbailey
Copy link
Member

pcbailey commented May 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member Author

metalice commented May 9, 2024

/retest

1 similar comment
@metalice
Copy link
Member Author

metalice commented May 9, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 0c2b925 into kubevirt-ui:main May 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants