-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-40445: Prevent reloading page when clicking on Degraded alerts #1941
CNV-40445: Prevent reloading page when clicking on Degraded alerts #1941
Conversation
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Prevent unnecessary reloading page when displaying Openshift Virtualization Degraded warning alerts page, displayed after clicking on "Warning" in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url. Fixes https://issues.redhat.com/browse/CNV-40445
a2473be
to
c9621f4
Compare
@avivtur @pcbailey @upalatucci @metalice please review |
@hstastna: This pull request references CNV-40445 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@avivtur @pcbailey @upalatucci @metalice please review |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-40445
Prevent unnecessary reloading whole page (incl. the whole left menu) when displaying Openshift Virtualization Degraded warning alerts page, displayed after clicking on Warning in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url.
🎥 Demo
Before:
reload_before.mp4
After:
reload_after.mp4