Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40445: Prevent reloading page when clicking on Degraded alerts #1941

Conversation

hstastna
Copy link

@hstastna hstastna commented May 13, 2024

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40445

Prevent unnecessary reloading whole page (incl. the whole left menu) when displaying Openshift Virtualization Degraded warning alerts page, displayed after clicking on Warning in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url.

🎥 Demo

Before:

reload_before.mp4

After:

reload_after.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 13, 2024

@hstastna: This pull request references CNV-40445 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40445

Prevent unnecessary reloading page when displaying Openshif tVirtualization Degraded warning alerts page, displayed after clicking on Warning in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url.

🎥 Demo

Before:

reload_before.mp4

After:

reload_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and yaacov May 13, 2024 14:20
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 13, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 13, 2024

@hstastna: This pull request references CNV-40445 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40445

Prevent unnecessary reloading page when displaying Openshift Virtualization Degraded warning alerts page, displayed after clicking on Warning in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url.

🎥 Demo

Before:

reload_before.mp4

After:

reload_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Prevent unnecessary reloading page when displaying
Openshift Virtualization Degraded warning alerts page, displayed after
clicking on "Warning" in the Overview > Status card's related
modal. Fix the not quite correct url of the page by adding missing "/"
to the beginning of the url.

Fixes https://issues.redhat.com/browse/CNV-40445
@hstastna hstastna force-pushed the BZ_OpenshiftVirtualization_Degraded_reload branch from a2473be to c9621f4 Compare May 13, 2024 14:21
@hstastna
Copy link
Author

@avivtur @pcbailey @upalatucci @metalice please review

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 13, 2024

@hstastna: This pull request references CNV-40445 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

Fixes:
https://issues.redhat.com/browse/CNV-40445

Prevent unnecessary reloading whole page (incl. the whole left menu) when displaying Openshift Virtualization Degraded warning alerts page, displayed after clicking on Warning in the Overview > Status card's related modal. Fix the not quite correct url of the page by adding missing "/" to the beginning of the url.

🎥 Demo

Before:

reload_before.mp4

After:

reload_after.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hstastna
Copy link
Author

@avivtur @pcbailey @upalatucci @metalice please review

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3ebb799 into kubevirt-ui:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants