Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-41385: Remove labels when auto-compute CPU limits is disabled #1942

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented May 14, 2024

📝 Description

This PR fixes a bug where the labels selected in the Auto-compute CPU Limits modal aren't deleted when the feature is disabled.

Jira: https://issues.redhat.com/browse/CNV-41385

🎥 Demo

Before

4.16-autocompute-cpu-limits-disabled--BEFORE---2024-05-14_06.24.23.mp4

After

4.16-autocompute-cpu-limits-disabled--AFTER---2024-05-14_06.22.40.mp4

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 14, 2024

@pcbailey: This pull request references CNV-41385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR fixes a bug where the labels selected in the Auto-compute CPU Limits modal aren't deleted when the feature is disabled.

Jira: https://issues.redhat.com/browse/CNV-41385

🎥 Demo

Coming

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 14, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 14, 2024

@pcbailey: This pull request references CNV-41385 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

📝 Description

This PR fixes a bug where the labels selected in the Auto-compute CPU Limits modal aren't deleted when the feature is disabled.

Jira: https://issues.redhat.com/browse/CNV-41385

🎥 Demo

Before

4.16-autocompute-cpu-limits-disabled--BEFORE---2024-05-14_06.24.23.mp4

After

4.16-autocompute-cpu-limits-disabled--AFTER---2024-05-14_06.22.40.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the bug-auto-compute-cpu-limits-disable-defunct branch from 1a2f7de to 05319dc Compare May 14, 2024 10:27
@pcbailey pcbailey changed the title WIP: CNV-41385: Remove labels when auto-compute CPU limits is disabled CNV-41385: Remove labels when auto-compute CPU limits is disabled May 14, 2024
@pcbailey pcbailey force-pushed the bug-auto-compute-cpu-limits-disable-defunct branch from 05319dc to 74876f7 Compare May 14, 2024 13:54
@pcbailey pcbailey force-pushed the bug-auto-compute-cpu-limits-disable-defunct branch from 74876f7 to 6054e46 Compare May 14, 2024 13:56
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3940540 into kubevirt-ui:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants