Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-45860: Deprecate CentOS 7 and CentOS Stream 8 #2132

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Aug 17, 2024

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 resources in the bootable volumes page, bootable volumes list on the InstanceTypes page, and the catalog Templates tab. It also adds filters to hide deprecated resources.

It also moves all badge components to a single folder.

Note: Selecting the filters by default will come in a follow-up PR.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 21-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

deprecate-centos7-8-templates-list--AFTER--2024-08-31 22-06

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 17, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 in the bootable volumes page and the bootable volumes list on the InstanceTypes page.

To Do: Filter out deprecated volumes.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Screenshots

deprecated-badges--boot-volumes-page--AFTER--2024-08-17_15-42

deprecated-badges--InstanceTypes-page--AFTER--2024-08-17_15-43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 17, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 17, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 in the bootable volumes page and the bootable volumes list on the InstanceTypes page.

It also moves all badge components to a single folder.

To Do: Filter out deprecated volumes.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Screenshots

deprecated-badges--boot-volumes-page--AFTER--2024-08-17_15-42

deprecated-badges--InstanceTypes-page--AFTER--2024-08-17_15-43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey
Copy link
Member Author

/retest

2 similar comments
@pcbailey
Copy link
Member Author

/retest

@pcbailey
Copy link
Member Author

/retest

@metalice
Copy link
Member

any update here?

@metalice
Copy link
Member

/retest

@pcbailey pcbailey force-pushed the feature-deprecate-centos-7-and-8 branch from 8b6d16f to d0633fa Compare August 31, 2024 21:05
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 31, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 in the bootable volumes page and the bootable volumes list on the InstanceTypes page.

It also moves all badge components to a single folder.

To Do: Filter out deprecated volumes.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 17-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the feature-deprecate-centos-7-and-8 branch from d0633fa to 8c0ea18 Compare September 1, 2024 01:43
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 1, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 in the bootable volumes page and the bootable volumes list on the InstanceTypes page.

It also moves all badge components to a single folder.

To Do: Filter out deprecated volumes.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 21-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 1, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 in the bootable volumes page and the bootable volumes list on the InstanceTypes page.

It also moves all badge components to a single folder.

To Do: Filter out deprecated volumes.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 21-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

deprecate-centos7-8-templates-list--AFTER--2024-08-31 22-06

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 1, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 resources in the bootable volumes page, bootable volumes list on the InstanceTypes page, and the catalog Templates tab. It also adds filters to hide deprecated resources.

It also moves all badge components to a single folder.

To Do: Make all of the hide deprecated resource filters checked by default.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 21-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

deprecate-centos7-8-templates-list--AFTER--2024-08-31 22-06

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey changed the title WIP: CNV-45860: Deprecate CentOS 7 and CentOS Stream 8 CNV-45860: Deprecate CentOS 7 and CentOS Stream 8 Sep 2, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 2, 2024

@pcbailey: This pull request references CNV-45860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

This PR adds deprecated badges to CentOS 7 and CentOS Stream 8 resources in the bootable volumes page, bootable volumes list on the InstanceTypes page, and the catalog Templates tab. It also adds filters to hide deprecated resources.

It also moves all badge components to a single folder.

Note: Selecting the filters by default will come in a follow-up PR.

Jira: https://issues.redhat.com/browse/CNV-45860

🎥 Demo

Bootable volumes list

deprecate-centos7-8-bootable-volumes--AFTER--2024-08-31 21-39

Create VM from InstanceTypes form

deprecate-centos7-8-instance-types--AFTER--2024-08-31 17-38

Templates list

deprecate-centos7-8-templates-list--AFTER--2024-08-31 22-06

Create VM from Templates form

deprecate-centos7-8-templates-catalog--AFTER--2024-08-31 16-54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the feature-deprecate-centos-7-and-8 branch from 8c0ea18 to 25c2933 Compare September 2, 2024 13:57
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 2, 2024
Copy link
Contributor

openshift-ci bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e3d7b18 into kubevirt-ui:main Sep 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants