Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-46589: Auto-generate meaningful snapshot names #2142

Conversation

pcbailey
Copy link
Member

📝 Description

Previously, auto-generated snapshot names provided no useful information outside of the VM name. This PR modifies the name format to add creation date and time information to make the auto-generated names more meaningful.

Jira: https://issues.redhat.com/browse/CNV-46589

🎥 Screenshots

Before

generate-snapshot-name--BEFORE--2024-08-21_09-08

After

generate-snapshot-name--AFTER--2024-08-21_09-03

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 21, 2024

@pcbailey: This pull request references CNV-46589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Previously, auto-generated snapshot names provided no useful information outside of the VM name. This PR modifies the name format to add creation date and time information to make the auto-generated names more meaningful.

Jira: https://issues.redhat.com/browse/CNV-46589

🎥 Screenshots

Before

generate-snapshot-name--BEFORE--2024-08-21_09-08

After

generate-snapshot-name--AFTER--2024-08-21_09-03

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Aug 21, 2024
@pcbailey pcbailey force-pushed the feature-generate-meaningful-snapshot-names branch from a8a3998 to 9f6f9d7 Compare August 21, 2024 13:20
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 21, 2024
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [avivtur,metalice,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metalice
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit dc7d852 into kubevirt-ui:main Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants