Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-47477: fix switching project from all-namespaces #2218

Merged

Conversation

upalatucci
Copy link
Member

📝 Description

Remove the useEffect that was causing a bug switching projects. Now the activeKey is not a state but we get it directly from the pathname.

useVirtualMachineInstanceTypes hook now has a third parameter that we need to use.

🎥 Demo

Before

Screen.Recording.2024-10-07.at.15.27.24.mov

After

Screen.Recording.2024-10-07.at.15.33.26.mov

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 7, 2024

@upalatucci: This pull request references CNV-47477 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

📝 Description

Remove the useEffect that was causing a bug switching projects. Now the activeKey is not a state but we get it directly from the pathname.

useVirtualMachineInstanceTypes hook now has a third parameter that we need to use.

🎥 Demo

Before

Screen.Recording.2024-10-07.at.15.27.24.mov

After

Screen.Recording.2024-10-07.at.15.33.26.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from metalice and tnisan October 7, 2024 13:42
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Oct 7, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 9, 2024
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fc9b12f into kubevirt-ui:main Oct 9, 2024
10 checks passed
@upalatucci
Copy link
Member Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2226

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants