Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2102475: Template example like fedora #713

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

upalatucci
Copy link
Member

@upalatucci upalatucci commented Jul 1, 2022

📝 Description

Make sure the Template example is shown like a fedora template.

  • fedora icon for template example
  • OS like other fedora distributions
  • filtered as a fedora template

Getting the OS key:
Before: getting the os distro key from the VM metadata vm.kubevirt.io/template annotation (indicate the template name used to create the VM like fedora-desktop-small).
After: use the proper annotation from VM -> spec -> template -> metadata -> annotation vm.kubevirt.io/os (annotation used to indicate the actual os key).

🎥 Demo

Screenshot from 2022-07-01 12-06-22

Screenshot from 2022-07-01 12-06-15

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@upalatucci: This pull request references Bugzilla bug 2102475, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2102475: Template example like fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@upalatucci: This pull request references Bugzilla bug 2102475, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2102475: Template example like fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2022

@upalatucci: This pull request references Bugzilla bug 2102475, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang July 1, 2022 10:15
@glekner
Copy link
Contributor

glekner commented Jul 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 3, 2022
@openshift-ci openshift-ci bot merged commit 824930d into kubevirt-ui:main Jul 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2022

@upalatucci: All pull requests linked via external trackers have merged:

Bugzilla bug 2102475 has been moved to the MODIFIED state.

In response to this:

Bug 2102475: Template example like fedora

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants