Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restruct 'clusteroverview' directory #727

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Jul 5, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

Resturctring the clusteroverview/overview/components directory

🎥 Demo

Before:

Screenshot from 2022-07-05 13-02-04

After:

Screenshot from 2022-07-05 13-01-37

Screenshot from 2022-07-05 13-12-07

@openshift-ci openshift-ci bot requested review from hstastna and yaacov July 5, 2022 10:04
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 5, 2022
@metalice
Copy link
Member

metalice commented Jul 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 5, 2022
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jul 5, 2022
@metalice
Copy link
Member

metalice commented Jul 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d00de80 into kubevirt-ui:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants