Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2104480: remove namespace from rules request #742

Conversation

metalice
Copy link
Member

@metalice metalice commented Jul 7, 2022

Signed-off-by: Matan Schatzman mschatzm@redhat.com

📝 Description

on production env, request to promethous /rules come back empty when there is namespace in the request.

🎥 Demo

Please add a video or an image of the behavior/changes

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

@metalice: This pull request references Bugzilla bug 2104480, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2104480: remove namespace from rules request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang July 7, 2022 07:22
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 7, 2022
@glekner
Copy link
Contributor

glekner commented Jul 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit c85e7c3 into kubevirt-ui:main Jul 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2022

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 2104480 has been moved to the MODIFIED state.

In response to this:

Bug 2104480: remove namespace from rules request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-high bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants