CNV-19275: Add virtctl to overview #746
Conversation
pcbailey
force-pushed
the
add-virtctl-to-overview
branch
2 times, most recently
from
1cff7b4
to
3ceb4ae
Compare
| }); | ||
|
|
||
| const tools = Array.isArray(cliTools) ? cliTools : [...[cliTools]]; | ||
| // skipcq: JS-0349 |
There was a problem hiding this comment.
does this skip DeepSource checks? why?
There was a problem hiding this comment.
useK8sWatchResource won't help in this case?
| const tools = Array.isArray(cliTools) ? cliTools : [...[cliTools]]; | ||
| // skipcq: JS-0349 | ||
| const virtctlObj = tools?.find( | ||
| (tool) => (tool as K8sResourceCommon)?.metadata?.name === VIRTCTL_DOWNLOADS, |
There was a problem hiding this comment.
u sure K8sResourceCommon and K8sResourceKind are mandatory here as hard casting?
There was a problem hiding this comment.
I typically don't hard cast unless I get errors, but I double-checked and was able to remove the hard cast to K8sResourceCommon, but the K8sResourceKind is needed to avoid an error as described in the DeepSource comment above.
|
Hi @pcbailey thanks for the PR. I left some small comments :) |
pcbailey
force-pushed
the
add-virtctl-to-overview
branch
from
3ceb4ae
to
34ed739
Compare
pcbailey
force-pushed
the
add-virtctl-to-overview
branch
from
34ed739
to
b6b8ac2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
This PR adds a link to the overview header that displays a popup with information on downloading
virtctlwhen clicked.Screenshots
Popup closed
Without the
Show getting started resourcesbuttonWith the
Show getting started resourcesbuttonPopup open
Without the
Show getting started resourcesbuttonWith the
Show getting started resourcesbutton