Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2103807: Name PVC source same as VM name when creating VM quickly #761

Conversation

hstastna
Copy link

📝 Description

Name the PVC source name the same as the VM name, according to the parameter NAME in the yaml used also for the PVC source name.

The problem was that the part of the processing template was omitted, when quick creating VM, comparing creating VM with the customization process. The parameter NAME was not properly set when quick creating VM.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2103807

🎥 Demo

Before:
quick_before
After:
quick_after

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2022

@hstastna: This pull request references Bugzilla bug 2103807, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2103807: Name PVC source same as VM name when creating VM quickly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang July 15, 2022 15:31
@hstastna
Copy link
Author

@avivtur
Copy link
Member

avivtur commented Jul 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jul 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, hstastna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jul 17, 2022
@openshift-ci openshift-ci bot merged commit 6397806 into kubevirt-ui:main Jul 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2022

@hstastna: All pull requests linked via external trackers have merged:

Bugzilla bug 2103807 has been moved to the MODIFIED state.

In response to this:

Bug 2103807: Name PVC source same as VM name when creating VM quickly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants