Adding the ability to start in pause mode #772
Conversation
DanaOrr
force-pushed
the
adding-start-in-pause-mode
branch
from
79b99b4
to
0ebad86
Compare
DanaOrr
force-pushed
the
adding-start-in-pause-mode
branch
from
0ebad86
to
a5efc43
Compare
| { | ||
| hasPendingChange: startStrategyChanged, | ||
| tabLabel: VirtualMachineDetailsTabLabel.Details, | ||
| label: t('Start in Pause Mode'), |
There was a problem hiding this comment.
please change to label: t('Start in pause mode')
| <FormGroup | ||
| fieldId="start-pause-mode" | ||
| helperText={t( | ||
| 'Applying the Start/Pause mode to this Virtual Machine will cause it to partially reboot and pause.', |
There was a problem hiding this comment.
please change to Applying the start/pause mode to this VirtualMachine will cause it to partially reboot and pause.
| id="start-pause-mode" | ||
| isChecked={checked} | ||
| onChange={setChecked} | ||
| label={t('Start this VirtualMachine in Pause mode')} |
There was a problem hiding this comment.
please change to Start this VirtualMachine in pause mode
| @@ -257,6 +258,24 @@ const VirtualMachineDetailsLeftGrid: React.FC<VirtualMachineDetailsLeftGridProps | |||
| } | |||
| data-test-id={`${vm?.metadata?.name}-boot-method`} | |||
| /> | |||
| <VirtualMachineDescriptionItem | |||
| descriptionData={vm?.spec?.template?.spec?.startStrategy ? t('ON') : t('OFF')} | |||
| descriptionHeader={t('Start in Pause Mode')} | |||
There was a problem hiding this comment.
please change to Start in pause mode
| isOpen={isOpen} | ||
| onClose={onClose} | ||
| onSubmit={onSubmit} | ||
| headerText={t('Start in Pause Mode')} |
There was a problem hiding this comment.
please change to Start in pause mode
| const updatedVirtualMachine = React.useMemo(() => { | ||
| const updatedVM = produce<V1VirtualMachine>(vm, (vmDraft: V1VirtualMachine) => { | ||
| ensurePath(vmDraft, ['spec.template.spec']); | ||
| vmDraft.spec.template.spec.startStrategy = checked ? 'Paused' : null; |
There was a problem hiding this comment.
please use printableVMStatus.Paused instead of hard-coded 'Paused'
| isOpen={isOpen} | ||
| onClose={onClose} | ||
| onSubmit={onSubmit} | ||
| headerText={t('Start in Pause Mode')} |
There was a problem hiding this comment.
please change to Start in pause mode
| const startStrategyChanged = getChangedStartStrategy( | ||
| vm, | ||
| vmi, | ||
| !!vm?.spec?.template?.spec?.startStrategy, |
There was a problem hiding this comment.
can be extracted from vm, no need to send another arg :)
| tabLabel: VirtualMachineDetailsTabLabel.Details, | ||
| label: t('Start in Pause Mode'), | ||
| handleAction: () => { | ||
| history.push(getTabURL(vm, VirtualMachineDetailsTab.Details)); |
DanaOrr
force-pushed
the
adding-start-in-pause-mode
branch
from
a5efc43
to
688ef1c
Compare
Signed-off-by: Dana Orr <dorr@redhat.com>
DanaOrr
force-pushed
the
adding-start-in-pause-mode
branch
from
688ef1c
to
01ee9bc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DanaOrr, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dana Orr dorr@redhat.com
📝 Description
Adding "Start in Pause mode" item to the Details tab.
🎥 Demo