CNV-19844: Adding utilization charts to vm metrics tab #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalice
force-pushed
the
CNV-19844-utilizaiton-chart-vm-metrics-tab
branch
2 times, most recently
from
0aeb451
to
6f86791
Compare
glekner
reviewed
Jul 20, 2022
| } | ||
| }, []); | ||
|
|
||
| useEffect(() => () => listener && listener(), [listener]); |
There was a problem hiding this comment.
can you make this effect more readable with blocks?.
also, don't you need a cleanup here?
glekner
reviewed
Jul 20, 2022
src/views/virtualmachines/details/tabs/metrics/virtual-machine-metrics-tab.scss
Show resolved
Hide resolved
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
CNV-19844-utilizaiton-chart-vm-metrics-tab
branch
from
6f86791
to
f5256ad
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glekner, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matan Schatzman mschatzm@redhat.com
📝 Description
Moving charts to shared locations.
Add a responsive hook, so charts resize will be dynamically
Add charts to the metrics tab
🎥 Demo