Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace column management #858

Merged

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Sep 5, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

Checking the namespace in the column management component when inside any project was not having any effect.
the fix includes hiding the namespace column since it's not manageable, and can't be disabled.

🎥 Demo

Before:

Peek.2022-09-05.15-23.mp4

After:

manage-namespace-after
manage-namespace-after2
manage-namespace-after3

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 5, 2022
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@metalice
Copy link
Member

metalice commented Sep 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Sep 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2ea5ea into kubevirt-ui:main Sep 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants