Refactor VMs per template card to be namespaced #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold Holding until openshift/console#12001 passes and the namespace bar can be added to the overview page. |
|
/retest |
pcbailey
force-pushed
the
refactor-vms-per-temp-for-ns
branch
from
311de14
to
0bdd2bd
Compare
|
/hold cancel |
upalatucci
reviewed
Sep 19, 2022
...lusteroverview/OverviewTab/running-vms-per-template-card/hooks/useVMsPerTemplateResources.ts
Outdated
Show resolved
Hide resolved
pcbailey
force-pushed
the
refactor-vms-per-temp-for-ns
branch
from
0bdd2bd
to
6c50b6c
Compare
metalice
reviewed
Sep 20, 2022
src/views/clusteroverview/OverviewTab/running-vms-per-template-card/VMsPerTemplateCard.tsx
Outdated
Show resolved
Hide resolved
metalice
reviewed
Sep 20, 2022
...lusteroverview/OverviewTab/running-vms-per-template-card/hooks/useVMsPerTemplateResources.ts
Outdated
Show resolved
Hide resolved
metalice
reviewed
Sep 20, 2022
src/views/clusteroverview/OverviewTab/running-vms-per-template-card/VMsPerTemplateCard.tsx
Outdated
Show resolved
Hide resolved
pcbailey
force-pushed
the
refactor-vms-per-temp-for-ns
branch
2 times, most recently
from
97affe6
to
73c8e63
Compare
pcbailey
force-pushed
the
refactor-vms-per-temp-for-ns
branch
from
73c8e63
to
52f536a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR refactors the VMs per template card to display data based on the selected namespace for admins and non-admins or all namespaces for admins.