Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2093771: The disk source should be PVC if the template has no auto-update boot source #899

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Bug 2093771: The disk source should be PVC if the template has no auto-update boot source #899

merged 1 commit into from
Oct 18, 2022

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Sep 29, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

Removing the "Template default" option when there's no default data source exists for the template

🎥 Demo

After:

no-template-default.mp4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022

@avivtur: This pull request references Bugzilla bug 2093771, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2093771: The disk source should be PVC if the template has no auto-update boot source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang September 29, 2022 12:05
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Sep 29, 2022
@avivtur avivtur force-pushed the change_disk_source_default branch 2 times, most recently from 9592806 to 99aef0f Compare October 3, 2022 08:14
@metalice
Copy link
Member

metalice commented Oct 3, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 3, 2022
@avivtur
Copy link
Member Author

avivtur commented Oct 3, 2022

/retest

1 similar comment
@hstastna
Copy link

hstastna commented Oct 3, 2022

/retest

@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Oct 6, 2022
@avivtur
Copy link
Member Author

avivtur commented Oct 6, 2022

/retest

1 similar comment
@avivtur
Copy link
Member Author

avivtur commented Oct 6, 2022

/retest

@metalice
Copy link
Member

metalice commented Oct 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 6, 2022
@avivtur
Copy link
Member Author

avivtur commented Oct 6, 2022

/retest

2 similar comments
@avivtur
Copy link
Member Author

avivtur commented Oct 6, 2022

/retest

@upalatucci
Copy link
Member

/retest

@avivtur
Bug 2093771: The disk source should be PVC if the template has no aut…
467cf9f 
…o-update boot source

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Oct 18, 2022
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7e49290 into kubevirt-ui:main Oct 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2093771 has been moved to the MODIFIED state.

In response to this:

Bug 2093771: The disk source should be PVC if the template has no auto-update boot source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

upalatucci pushed a commit to upalatucci/kubevirt-plugin that referenced this pull request Oct 19, 2022
@openshift-merge-robot @upalatucci
Merge pull request kubevirt-ui#899 from avivtur/change_disk_source_de…
1bfa3bf 
…fault

Bug 2093771: The disk source should be PVC if the template has no auto-update boot source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstastna hstastna Awaiting requested review from hstastna

@yaacov yaacov Awaiting requested review from yaacov

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@metalice metalice

Labels
approved This issue is something we want to fix bugzilla/severity-medium bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avivtur @metalice @hstastna @upalatucci @openshift-merge-robot