Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2139687: catalog shows template list for non-priv users #947

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Nov 3, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

Non-privileged user could see the template's list in the catalog and under a namespace with no permissions can also click the template and crash when clicking on customize vm

🎥 Demo

Before

can-click-template-catalog-no-permissions-b4.mp4

catalog-shows-templates-when-cant-process-template-b4

After

catalog-shows-templates-when-cant-process-template-with-ns
catalog-shows-templates-when-cant-process-template-with-ns-permissions
catalog-shows-templates-when-cant-process-template

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@avivtur: This pull request references Bugzilla bug 2139687, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2139687: catalog shows template list for non-priv users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 3, 2022
@openshift-ci openshift-ci bot requested a review from gouyang November 3, 2022 09:31
Copy link
Member

@upalatucci upalatucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 3, 2022
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the catalog_display_error_for_non_priv_user branch from 99bf22a to 024e49e Compare November 3, 2022 12:01
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Nov 3, 2022
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6c846cc into kubevirt-ui:main Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2139687 has been moved to the MODIFIED state.

In response to this:

Bug 2139687: catalog shows template list for non-priv users

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-unspecified bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants