Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2143498: Could not load template while creating VM from catalog #973

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Nov 17, 2022

Signed-off-by: Aviv Turgeman aturgema@redhat.com

📝 Description

workaround to failing proccessTemplate request as namespace of request call e.g. the active namespace is not the same as the namespace of the proccessed Template (regression from v4.12.0-151)

🎥 Demo

Before

Screenshare.-.2022-11-17.11_17_25.AM.mp4

After

proccess-template.mp4

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2022

@avivtur: This pull request references Bugzilla bug 2143498, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "4.12.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2143498: Could not load template while creating VM from catalog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Nov 17, 2022
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Nov 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member

/retitle ' Bug 2143498: Could not load template while creating VM from catalog'

@openshift-ci openshift-ci bot changed the title Bug 2143498: Could not load template while creating VM from catalog ' Bug 2143498: Could not load template while creating VM from catalog' Nov 18, 2022
@upalatucci
Copy link
Member

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

@upalatucci: This pull request references Bugzilla bug 2143498, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.13.0) matches configured target release for branch (4.13.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang November 18, 2022 14:34
@openshift-merge-robot openshift-merge-robot merged commit 274f747 into kubevirt-ui:main Nov 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2143498 has been moved to the MODIFIED state.

In response to this:

' Bug 2143498: Could not load template while creating VM from catalog'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upalatucci
Copy link
Member

/cherrypick release-4.12

@upalatucci
Copy link
Member

/retitle Bug 2143498: Could not load template while creating VM from catalog

@openshift-ci openshift-ci bot changed the title ' Bug 2143498: Could not load template while creating VM from catalog' Bug 2143498: Could not load template while creating VM from catalog Nov 18, 2022
@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #974

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix bugzilla/severity-urgent bugzilla/valid-bug lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants