-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider newer topology labels in zone controller #11
Conversation
0935c69
to
b7cd2f6
Compare
/cc @afritzler @gonzolino |
@stoyanr: GitHub didn't allow me to request PR reviews from the following users: afritzler. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gonzolino The Travis build fails with:
I don't think this failure has anything to do with my changes. I would like to retrigger the build, but I don't seem to be able to do this from Travis. Is there a way? |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't reproduce the travis error on my local machine...
Please adress the comment from teh review, then we can trigger a retest. It's probably just some error on travis.
Signed-off-by: Stoyan Rachev <s.rachev@sap.com>
b7cd2f6
to
b691231
Compare
Add "io.openshift.release.operator" label to the Dockerfile
This PR adds code to consider the newer
topology
labels in the zone controller, in addition to the olderfailure-domain
ones. According to https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/, starting in v1.17, thefailure-domain.beta.kubernetes.io/region
label is deprecated in favor oftopology.kubernetes.io/region
, and thefailure-domain.beta.kubernetes.io/zone
label is deprecated in favor oftopology.kubernetes.io/zone
.Since the cloud provider still vendors Kubernetes 1.16, the newer labels of the underkube nodes will be considered when determining the region and zone, but not actually added to the overkube nodes (as this is done by the vendored code). Vendoring a newer Kubernetes version is unfortunately close to impossible since kubevirt.io/client-go is still based on 1.16 and there are conflicts, see also #10.