Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-0.65, operator: Adapt to k8s-1.25 security restrictions #1412

Merged
merged 1 commit into from
Sep 13, 2022
Merged

release-0.65, operator: Adapt to k8s-1.25 security restrictions #1412

merged 1 commit into from
Sep 13, 2022

Conversation

qinqon
Copy link
Collaborator

@qinqon qinqon commented Sep 12, 2022

Signed-off-by: Enrique Llorente ellorent@redhat.com

What this PR does / why we need it:
Cherry pick from #1401

Special notes for your reviewer:

Release note:

Fix operator pod and container security context for k8s-1.25

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 12, 2022
@qinqon qinqon requested a review from RamLavi September 12, 2022 15:34
@qinqon qinqon changed the title operator: Adapt to k8s-1.25 security restrictions release-0.65, operator: Adapt to k8s-1.25 security restrictions Sep 12, 2022
@RamLavi
Copy link
Collaborator

RamLavi commented Sep 13, 2022

/retest

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 13, 2022

/lgtm
/approve
/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@qinqon
Copy link
Collaborator Author

qinqon commented Sep 13, 2022

/hold
seccomp is different for OCP 4.10

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@qinqon
operator: Adapt to k8s-1.25 security restrictions
7e12947 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the cherry-pick-1401-to-release-0.65 branch from d38a152 to 7e12947 Compare September 13, 2022 08:07
@kubevirt-bot kubevirt-bot added size/XS and removed lgtm Indicates that a PR is ready to be merged. size/S labels Sep 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RamLavi
RamLavi approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@qinqon
Copy link
Collaborator Author

qinqon commented Sep 13, 2022

/override pull-e2e-cnao-nmstate-functests-release-0.65

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-e2e-cnao-nmstate-functests-release-0.65

In response to this:

/override pull-e2e-cnao-nmstate-functests-release-0.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link
Collaborator Author

qinqon commented Sep 13, 2022

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022
@kubevirt-bot kubevirt-bot merged commit 458c8d9 into kubevirt:release-0.65 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamLavi RamLavi RamLavi approved these changes

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@RamLavi RamLavi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinqon @RamLavi @kubevirt-bot