-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovs: Fix ovs cni bumper and bump ovs-cni #1822
Conversation
Since the image repository was changed, the scripts had to be updated. Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval: GitHub didn't allow me to request PR reviews from the following users: ram. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. |
/cc @RamLavi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oshoval don't you want to only fix the script and wait until the auto bumper works?
It would be a good validation..
No need, i ran the script manually, to validate it, the script did those changes, not manual Moreover it is better to have them both aligned (hence together), splitting it is confusing and not required |
soon i am going to fix another thing on OVS and it will then ran the bumper again once there is a new version this PR is totally safe imo |
We must have them together but we can't just change the image name without the hash |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Since the image repository was changed, the scripts had to be updated.
bump ovs-cni to v0.34.0
Special notes for your reviewer:
Release note: