Skip to content

Commit

Permalink
Verify metrics docs are updated (#2356)
Browse files Browse the repository at this point in the history
* Verify metrics docs are updated

Signed-off-by: João Vilaça <jvilaca@redhat.com>

* Add hack/diff-csv.sh

Signed-off-by: João Vilaça <jvilaca@redhat.com>

* Remove double / in path

Signed-off-by: João Vilaça <jvilaca@redhat.com>
  • Loading branch information
machadovilaca committed Jul 15, 2022
1 parent efe5109 commit 1914fdd
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 4 deletions.
9 changes: 5 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,11 @@ clean:
update-codegen:
${DO_BAZ} "./hack/update-codegen.sh"

generate: update-codegen bazel-generate
generate: update-codegen bazel-generate generate-doc

generate-verify:
generate-verify: generate-doc
${DO_BAZ} "./hack/verify-codegen.sh"
git difftool -y --trust-exit-code --extcmd=./hack/diff-csv.sh

gomod-update:
${DO_BAZ} "./hack/build/dep-update.sh"
Expand Down Expand Up @@ -151,10 +152,10 @@ openshift-ci-image-push:
./hack/build/osci-image-builder.sh

generate-doc: build-docgen
_out/metricsdocs > doc/metrics.md
_out/tools/metricsdocs/metricsdocs > doc/metrics.md

build-docgen:
go build -ldflags="-s -w" -o _out/metricsdocs ./tools/metricsdocs
./hack/build/bazel-build-metricsdocs.sh

help:
@echo "Usage: make [Targets ...]"
Expand Down
38 changes: 38 additions & 0 deletions hack/build/bazel-build-metricsdocs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#!/bin/bash
#
# This file is part of the KubeVirt project
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# Copyright 2022 Red Hat, Inc.
#

set -e

source hack/build/common.sh
source hack/build/config.sh

rm -rf ${CMD_OUT_DIR}
mkdir -p ${CMD_OUT_DIR}/dump

# Build all binaries for amd64
bazel build \
--verbose_failures \
--config=${ARCHITECTURE} \
//tools/metricsdocs/...

rm -rf _out/tools/metricsdocs
mkdir -p _out/tools/metricsdocs
cp ./bazel-bin/tools/metricsdocs/metricsdocs_/metricsdocs _out/tools/metricsdocs/

bazel clean
7 changes: 7 additions & 0 deletions hack/diff-csv.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#!/bin/bash
# Usage:
#
# git difftool -y --extcmd=hacks/diff-csv.sh
#
# currently used for make sanity
diff --unified=1 --ignore-matching-lines='^\s*createdAt:' $@

0 comments on commit 1914fdd

Please sign in to comment.