fix golang ci lint

Signed-off-by: menyakun <lxs137@hotmail.com>

pkg/image/filefmt.go

@@ -15,6 +15,7 @@ import (
 //	creates the destination file too large, by the difference between this const and 512.
 const MaxExpectedHdrSize = 512
 
+// CompressedFormat return whether file format is compressed
 func CompressedFormat(format string) bool {
 	return format == "gz" || format == "xz" || format == "zst"
 }

pkg/importer/format-readers.go

@@ -76,7 +76,7 @@ type knownExtFileMatcher struct {
 	firstCalledFilepath *string
 }
 
-func NewKnownExtFileMatcher() *knownExtFileMatcher {
+func newKnownExtFileMatcher() *knownExtFileMatcher {
 	return &knownExtFileMatcher{
 		calledFilepath: map[string]struct{}{},
 	}
@@ -301,7 +301,7 @@ func (fr *FormatReaders) xzReader() (io.Reader, error) {
 	return xz, nil
 }
 
-func (fr *FormatReaders) AppendArchiveInnerFileReader(matcher util.FileMatcher) {
+func (fr *FormatReaders) appendArchiveInnerFileReader(matcher util.FileMatcher) {
 	if !fr.ArchiveTar || fr.readers[len(fr.readers)-1].rdrType == rdrTar {
 		return
 	}

pkg/importer/http-datasource.go

@@ -141,13 +141,13 @@ func (hs *HTTPDataSource) Info() (ProcessingPhase, error) {
 	}
 	if hs.readers.ArchiveTar {
 		if hs.readers.Compressed {
-			hs.readers.AppendArchiveInnerFileReader(NewKnownExtFileMatcher())
+			hs.readers.appendArchiveInnerFileReader(newKnownExtFileMatcher())
 			// for unseekable compressed tar archive (gzip, xz with large block size),
 			// qemu-img over nbdkit will be super slow,
 			// so fallback to download to scratch
 			return ProcessingPhaseTransferScratch, nil
 		}
-		matcher := NewKnownExtFileMatcher()
+		matcher := newKnownExtFileMatcher()
 		innerFilepath, _, err := util.FindTarInnerFile(hs.readers.TopReader(), matcher)
 		if err != nil {
 			return ProcessingPhaseError, err

pkg/util/util.go

@@ -465,6 +465,7 @@ func ResolveVolumeMode(volumeMode *v1.PersistentVolumeMode) v1.PersistentVolumeM
 	return retVolumeMode
 }
 
+// FileMatcher is a interface of file path matcher
 type FileMatcher interface {
 	Match(filepath string) bool
 }
@@ -476,13 +477,16 @@ type TarReader struct {
 	innerReader      io.Reader
 }
 
+// NewTarReader construct TarReader
 func NewTarReader(reader io.Reader, matcher FileMatcher) *TarReader {
 	return &TarReader{
 		Reader:           reader,
 		InnerFileMatcher: matcher,
 	}
 }
 
+// Read reads bytes from the inner reader,
+// the inner reader point to the tar inner file
 func (r *TarReader) Read(p []byte) (n int, err error) {
 	if r.innerReader == nil {
 		_, innerReader, err := FindTarInnerFile(r.Reader, r.InnerFileMatcher)
@@ -496,7 +500,7 @@ func (r *TarReader) Read(p []byte) (n int, err error) {
 	return r.innerReader.Read(p)
 }
 
-// find the first file path and it's reader meet matcher in tar archive,
+// FindTarInnerFile find the first file path and it's reader meet matcher in tar archive,
 func FindTarInnerFile(reader io.Reader, matcher FileMatcher) (filepath string, innerFileReader io.Reader, err error) {
 	tarReader := tar.NewReader(reader)
 	for {

tests/utils/fileConversion.go

@@ -94,6 +94,7 @@ func ArchiveFiles(targetFile, tgtDir string, sourceFilesNames ...string) (string
 	return tgtPath, nil
 }
 
+// ToGz create gzipped src file into tgtDir wit extension
 func ToGz(src, tgtDir, ext string) (string, error) {
 	tgtFile, tgtPath, _ := createTargetFile(src, tgtDir, image.ExtGz)
 	defer tgtFile.Close()
@@ -137,6 +138,7 @@ func toZst(src, tgtDir, ext string) (string, error) {
 	return tgtPath, nil
 }
 
+// ToXz create xz src file into tgtDir wit extension
 func ToXz(src, tgtDir, ext string) (string, error) {
 	tgtFile, tgtPath, _ := createTargetFile(src, tgtDir, image.ExtXz)
 	defer tgtFile.Close()