Change +build ignore tag in tools.go to +build codegen #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make deps-update will not ignore it and properly vendor in k8s.io/code-generator. By using the +build tag will cause the build to not include this code during a build unless the codegen tag is used. // +build ignore is special apparently golang/go#29598 Signed-off-by: Alexander Wels <awels@redhat.com>
kubevirt-bot
added
release-note-none
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that make deps-update will not ignore it and properly vendor in k8s.io/code-generator.
By using the +build tag will cause the build to not include this code
during a build unless the codegen tag is used.
// +build ignore is special apparently
golang/go#29598
Signed-off-by: Alexander Wels awels@redhat.com
What this PR does / why we need it:
Fix make deps-update to properly vendor in code-generator.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: