[release-v1.43] Delete erroneous DVs on DataImportCron digest update #2220
Conversation
kubevirt-bot
added
release-note
Manual backport of kubevirt#2169 When a DataImportCron import DV is condition Running=False with Reason=Error it indicates this DIC might get stuck with this DV forever, so no new import DVs will be created even if the source sha256 is updated. With this change, when digest is updated, before creating the new DV, we simply delete the erroneous DV if necessary. Added a timeout to the importer cmd wait for server ready file, so it exits with error and termination message used by DV Running condition. Also includes some DataImportCron tests improvements and cleanup. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
delete_dic_dv_on_error_v1.43
branch
from
75464bd
to
715fed8
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/override pull-containerized-data-importer-e2e-k8s-1.21-ceph |
|
@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-ceph In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual backport of #2169
When a DataImportCron import DV is condition Running=False with
Reason=Error it indicates this DIC might get stuck with this DV forever,
so no new import DVs will be created even if the source sha256 is
updated. With this change, when digest is updated, before creating the
new DV, we simply delete the erroneous DV if necessary.
Added a timeout to the importer cmd wait for server ready file, so it
exits with error and termination message used by DV Running condition.
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Also includes some DataImportCron tests improvements and cleanup
Release note: