Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.43] Expose all CDI CRDs to cluster-readers #2246

Merged

Conversation

arnongilboa
Copy link
Collaborator

What this PR does / why we need it:

Manual backport of #2245

Add get/list/watch cluster RBAC to:

  • cdiconfigs.cdi.kubevirt.io
  • dataimportcrons.cdi.kubevirt.io
  • datasources.cdi.kubevirt.io
  • objecttransfers.cdi.kubevirt.io
  • storageprofiles.cdi.kubevirt.io

Signed-off-by: Arnon Gilboa agilboa@redhat.com

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Expose all CDI CRDs to cluster-readers

Manual backport of kubevirt#2245

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 25, 2022
@awels
Copy link
Member

awels commented Apr 25, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 25, 2022
@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. size/S labels Apr 25, 2022
@awels
Copy link
Member

awels commented Apr 25, 2022

/hold
/approve

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@arnongilboa
Copy link
Collaborator Author

/test pull-cdi-linter

@awels
Copy link
Member

awels commented Apr 25, 2022

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2022
@arnongilboa
Copy link
Collaborator Author

/test pull-containerized-data-importer-e2e-k8s-1.21-ceph

@kubevirt-bot
Copy link
Contributor

@arnongilboa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-containerized-data-importer-e2e-ceph
  • /test pull-containerized-data-importer-e2e-hpp-previous

The following commands are available to trigger optional jobs:

  • /test pull-cdi-apidocs
  • /test pull-cdi-generate-verify
  • /test pull-cdi-linter
  • /test pull-cdi-unit-test

Use /test all to run all jobs.

In response to this:

/test pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arnongilboa
Copy link
Collaborator Author

/retest

@awels
Copy link
Member

awels commented Apr 26, 2022

/test pull-containerized-data-importer-e2e-ceph

@arnongilboa
Copy link
Collaborator Author

/retest

1 similar comment
@awels
Copy link
Member

awels commented Apr 26, 2022

/retest

@awels
Copy link
Member

awels commented Apr 26, 2022

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

@kubevirt-bot
Copy link
Contributor

@awels: Overrode contexts on behalf of awels: pull-containerized-data-importer-e2e-k8s-1.21-ceph

In response to this:

/override pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented Apr 26, 2022

/test pull-containerized-data-importer-e2e-ceph

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 26, 2022

@arnongilboa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerized-data-importer-e2e-k8s-1.21-ceph 9e80a56 link true /test pull-containerized-data-importer-e2e-k8s-1.21-ceph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@awels
Copy link
Member

awels commented Apr 26, 2022

/test pull-containerized-data-importer-e2e-ceph

@kubevirt-bot kubevirt-bot merged commit bd6b58a into kubevirt:release-v1.43 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants