[release-v1.43] Start smart clone controller from datavolume controller when needed backport #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
…ubevirt#2265) * periodic sync CSI snapshot CRD check It was possible for the CSI snapshot CRD check to fail silently and prevent the smart clone controller from starting during the cdi deployment pod start up. This would prevent smart clone from working properly. This adds a periodic sync of 1 minute for checking the CRDs. We also log failures that are not is not found so we can more easily detect this situation as humans. Signed-off-by: Alexander Wels <awels@redhat.com> * Change location of the start controller call. Signed-off-by: Alexander Wels <awels@redhat.com>
awels
force-pushed
the
smartclone_controller-b
branch
from
1bfef4b
to
fcbdb4c
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Wels awels@redhat.com
What this PR does / why we need it:
It was possible for the CSI snapshot CRD check to fail silently and prevent the smart clone controller from starting during the cdi deployment pod start up. This would prevent smart clone from working properly.
This moves the creation of the smart clone controller into the datavolume controller when someone attempts to do a smart clone. Until that happens the smart clone controller is not started at all. To ensure we don't have multiple smart clone controllers started, we use a channel to synchronize creation, and once created the function will be a no-op.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: