Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty to DataSourceStatus.source #2382

Merged

Conversation

arnongilboa
Copy link
Collaborator

Signed-off-by: Arnon Gilboa agilboa@redhat.com

What this PR does / why we need it:
Making this new status field required in the JSON, breaks API backward compatibility, so omitempty is added.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 8, 2022
@awels
Copy link
Member

awels commented Aug 8, 2022

Whoops should have had that in the original PR.

@ShellyKa13
Copy link
Contributor

maybe add the PR description to the commmit msg

@awels
Copy link
Member

awels commented Aug 8, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
Making this new status field required in the JSON breaks API backward
compatibility, so omitempty is added.

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@ShellyKa13
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@kubevirt-bot kubevirt-bot merged commit 11b4115 into kubevirt:main Aug 8, 2022
@oshoval
Copy link

oshoval commented Aug 17, 2022

can a new release be created please ?
so kubevirtci will use it and fix the problem you mentioned
kubevirt/kubevirt#8292 (comment)

@akalenyu
Copy link
Collaborator

/cherrypick release-v1.53

@kubevirt-bot
Copy link
Contributor

@akalenyu: new pull request created: #2398

In response to this:

/cherrypick release-v1.53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants