Always set a valid ContentType for created PVC #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When DV is garbage collected and PVC ContentType is not correctly set, there is no way to guess the PVC ContetType. In CDI we assume that if there is no content type it's a kubevirt disk, but is other cases (e.g. export) we cannot make that assumption. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
kubevirt-bot
added
release-note-none
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
lgtm
|
/test pull-containerized-data-importer-e2e-nfs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arnon Gilboa agilboa@redhat.com
What this PR does / why we need it:
When DV is garbage collected and PVC ContentType is not correctly set, there is no way to guess the PVC ContetType. In CDI we assume that if there is no content type it's a kubevirt disk, but is other cases (e.g. export) we cannot make that assumption.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: