Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure host assisted concurrent clone test runs on all storages #2575

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

akalenyu
Copy link
Collaborator

@akalenyu akalenyu commented Feb 6, 2023

Signed-off-by: Alex Kalenyuk akalenyu@redhat.com

What this PR does / why we need it:
Also, make some changes to the test to catch
#2550

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 6, 2023
@akalenyu
Copy link
Collaborator Author

akalenyu commented Feb 6, 2023

/hold
obv can't merge since this fails
/cc @awels

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@akalenyu
Copy link
Collaborator Author

akalenyu commented Feb 6, 2023

/test pull-containerized-data-importer-e2e-ceph

@akalenyu
Copy link
Collaborator Author

/hold cancel
CI does not catch #2550. May have to do with the type of storage we have backing ceph on CI

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2023
@akalenyu
Copy link
Collaborator Author

/test all

Also, make some changes to the test to catch
kubevirt#2550

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@awels
Copy link
Member

awels commented Apr 12, 2023

/test pull-containerized-data-importer-e2e-nfs

@awels
Copy link
Member

awels commented Apr 12, 2023

/lgtm
/approve
#2647 will have a conflict here I think since that one modifies some of these tests.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@kubevirt-bot kubevirt-bot merged commit f9c049f into kubevirt:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants