Enable DV status subresource #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
arnongilboa
force-pushed
the
dv_status_subresource
branch
3 times, most recently
from
2c8ce43
to
b6b2774
Compare
arnongilboa
force-pushed
the
dv_status_subresource
branch
from
b6b2774
to
f2b9883
Compare
awels
reviewed
Mar 1, 2023
| @@ -825,7 +823,7 @@ func (r *ReconcilerBase) emitEvent(dataVolume *cdiv1.DataVolume, dataVolumeCopy | |||
| } | |||
| // Only update the object if something actually changed in the status. | |||
| if !reflect.DeepEqual(dataVolume.Status, dataVolumeCopy.Status) { | |||
| if err := r.updateDataVolume(dataVolumeCopy); err != nil { | |||
| if err := r.updateDataVolumeStatus(dataVolumeCopy); err != nil { | |||
| r.log.Error(err, "Unable to update datavolume", "name", dataVolumeCopy.Name) | |||
There was a problem hiding this comment.
Maybe change the error to unable to update datavolume status ?
arnongilboa
force-pushed
the
dv_status_subresource
branch
2 times, most recently
from
e63d11e
to
17d44f0
Compare
DV status can now be updated only by UpdateStatus() and no more by Update(), so regular users cannot update status without special permission. In addition, updating just the status would not update the generation of the object, so we’ll have less “object has been modified” errors in the reconcile loops. Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
arnongilboa
force-pushed
the
dv_status_subresource
branch
from
17d44f0
to
3317780
Compare
kubevirt-bot
added
release-note
|
/approve Now let's do this with our other CRDs! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherrypick release-v1.56 |
|
@arnongilboa: new pull request created: #2626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DataVolume.Statuscan now be updated only byUpdateStatus()and no more byUpdate(), so regular users cannot updateStatuswithout special permission. In addition, updating just theStatuswould not update theGenerationof the object, so we’ll have lessobject has been modifiederrors in the reconcile loops.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: