Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PVC if possible even if the StorageClass is missing #2683

Merged
merged 2 commits into from
May 2, 2023
Merged

Create PVC if possible even if the StorageClass is missing #2683

merged 2 commits into from
May 2, 2023
+447 −100

Commits on Apr 30, 2023

  1. Create PVC if possible even if SC is missing 

    When PVC is created with storageClassName and the SC is not found,
k8s looks for PV with the storageClassName for satisfying this claim.
In this case k8s supports also a blank (“”, not the nil default one)
storageClassName. To support this behavior we added:
-DV controller support for this flow (for both “” and non-existing SC)
-Condition update and event when StorageSpec PVC rendering errors and
 PVC is not created (e.g. missing both AccessModes and SC/PV)
-PVC is created even if a satisfying SC/PV doesn't exist if pvc/storage
 AccessModes is set (otherwise k8s PVC validation fails). PVC/DV phase
 will be Pending until a satisfying SC/PV is found
-PV watch to reconcile DVs waiting for the PV storageClassName
-PV storageClassName indexer, so we can list the relevant PVs

Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    ea9bc21 View commit details
    Browse the repository at this point in the history

  2. CR fixes 

    Signed-off-by: Arnon Gilboa <agilboa@redhat.com>
    @arnongilboa
    arnongilboa committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    137ec17 View commit details
    Browse the repository at this point in the history