update k8s libs to 1.26. #2687
update k8s libs to 1.26. #2687
Conversation
kubevirt-bot
added
release-note
|
hmm looks like they changed the quota message format again, and the tests are failing because the string isn't being matched. |
Yeah controller runtime added an additional field to the log, those checks are redundant IMO so removed them |
|
@awels how do we deal with the fossa fails? |
|
I usually have to go into the fossa tool to mark whatever is the problem, as not a problem because reasons. |
|
/test pull-containerized-data-importer-fossa |
|
/retest-required |
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
… has changed Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
| @@ -2235,14 +2235,6 @@ var _ = Describe("all clone tests", func() { | |||
|
|
|||
| f.ForceBindPvcIfDvIsWaitForFirstConsumer(dataVolume) | |||
|
|
|||
| By("Verify Quota was exceeded in logs") | |||
| matchString := strings.Trim(fmt.Sprintf("\"namespace\": \"%s\", \"error\": \"pods \\\"cdi-upload-target-dv\\\" is forbidden: exceeded quota: test-quota, requested", targetNs.Name), " ") | |||
There was a problem hiding this comment.
Do we know if the new quota message still matches the ErrQuotaExceeded function that we use in the dv controllers?
There was a problem hiding this comment.
If you look at the file we still verify a condition and an event contain ErrExceededQuota
| k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed | ||
| k8s.io/cluster-bootstrap v0.26.1 | ||
| k8s.io/code-generator v0.26.1 | ||
| k8s.io/component-helpers v0.26.1 |
There was a problem hiding this comment.
can swap the copied funcs like
There was a problem hiding this comment.
we also copied CheckAccessModes :donthateme:
There was a problem hiding this comment.
lol good call, just updated
|
/retest-required |
Signed-off-by: Michael Henriksen <mhenriks@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Been awhile since we updated libs!
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Couple thinks that came along with this that may be interesting...
PVC
spec.dataSourceRefhasnamespacefield now but we will not allow it.ConfigMap based leaderelection is gone, fortunately we were doing configmap + leases for awhile, so we should be good.
Release note: