Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import populator #2690

Merged
merged 8 commits into from
Apr 27, 2023
Merged

Import populator #2690

merged 8 commits into from
Apr 27, 2023

Commits on Apr 27, 2023

  1. Create populators package to be used for all populators 

    This commit introduces the basic reconciler for
populators with common function that can be used
by the different populators.

Signed-off-by: Shelly Kagan <skagan@redhat.com>
    @ShellyKa13 @alromeros
    ShellyKa13 authored and alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    05ee29d View commit details
    Browse the repository at this point in the history

  2. unite getcontenttype func across code 

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    @ShellyKa13 @alromeros
    ShellyKa13 authored and alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    75d9d62 View commit details
    Browse the repository at this point in the history

  3. Add VolumeImportSource CRD for import populator 

    This commit adds the VolumeImportSource CRD into CDI.

CRs created from this CRD will be referenced in the dataSourceRef field to populate PVCs with the import populator.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    96b00d9 View commit details
    Browse the repository at this point in the history

  4. Refactor common populator code to be shared among all populators 

    This commit introduces and modifies several functions so we can reuse common code between all populators.

Other than having a common reconcile function, a new populatorController interface has been introduced so we are able to call populator-specific methods from the populator-base reconciler.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    f5904de View commit details
    Browse the repository at this point in the history

  5. Create Import Populator 

    The import populator is a controller that handles the import of data in PVCs without the need of DataVolumes while still taking advantage of the import-controller flow.

This controller creates an additional PVC' with import annotations. After the import process succeeds, the controller rebinds the PV to the original target PVc and deletes the PVC prime.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3ef599d View commit details
    Browse the repository at this point in the history

  6. Add functional tests to cover the import populator flow 

    This commit updates the import tests to cover the new import populator flow.

Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    8f68f0f View commit details
    Browse the repository at this point in the history

  7. Add unit tests for import populator 

    Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    3bf06a8 View commit details
    Browse the repository at this point in the history

  8. Minor fixes and enhancements in import/common populator code 

    * Modify indexes and other related code to support namespaced dataSourceRefs. Cross-namespace population is still not supported as it depends on alpha feature gates.
* Add functional test to cover static binding.
* Fix selected node annotation bug in scratch space PVCs
* Fix linter alerts

Signed-off-by: Alvaro Romero <alromero@redhat.com>
    @alromeros
    alromeros committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    702ee39 View commit details
    Browse the repository at this point in the history