Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple clone functional test #2704

Closed
wants to merge 1 commit into from
Closed

Fix multiple clone functional test #2704

wants to merge 1 commit into from

Conversation

awels
Copy link
Member

@awels awels commented Apr 28, 2023

What this PR does / why we need it:
The test was failing due to a type mismatch in the comparison (int vs int32).
The destructive lane is failing due to a cdi pod not comping back up in time. Added some extra logging to determine why

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 28, 2023
@awels
Copy link
Member Author

awels commented Apr 28, 2023

/retest-required

@mhenriks
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@awels
Fix multiple clone functional test
1e41a4f 
The test was failing due to a type mismatch in the comparison
(int vs int32).
The destructive lane is failing due to a cdi pod not comping back
up in time. Added some extra logging to determine why

Signed-off-by: Alexander Wels <awels@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2023
@kubevirt-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 28, 2023 •
edited

@awels: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-linter 1e41a4f link false /test pull-cdi-linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

akalenyu
akalenyu reviewed Apr 30, 2023
View reviewed changes
tests/cloner_test.go
@@ -1021,7 +1021,7 @@ var _ = Describe("all clone tests", func() {
Expect(err).ToNot(HaveOccurred())
restartCount := cloner.Status.ContainerStatuses[0].RestartCount
fmt.Fprintf(GinkgoWriter, "INFO: restart count on clone source pod %s: %d\n", clonerPodName, restartCount)
Expect(restartCount).To(BeNumerically("<", 2))
Expect(restartCount).To(BeNumerically("<", int32(2)))
Copy link
Collaborator

@akalenyu akalenyu Apr 30, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you look at the failure https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/2701/pull-containerized-data-importer-e2e-ceph/1651557222200643584
the issue here is that 2 is too high for this test to pass
Expected : 2 to be < : 2

We have a PR pending that disables this check (explanation in comment):
#2647 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exactly failure I was seeing is that the type didn't match int vs int32 so I just cast it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the matcher should play along with that, the full output looks like:

{ Failure /root/go/src/kubevirt.io/containerized-data-importer/tests/cloner_test.go:965
Expected
    <int32>: 2
to be <
    <int>: 2
/root/go/src/kubevirt.io/containerized-data-importer/tests/cloner_test.go:1024}

tests/operator_test.go
return len(cdiPods.Items) == len(newCdiPods.Items)
fmt.Fprintf(GinkgoWriter, "number of cdi pods: %d\n new number of cdi pods: %d\n", len(cdiPods.Items), len(newCdiPods.Items))
for _, pod := range newCdiPods.Items {
fmt.Fprintf(GinkgoWriter, "pod %s/%s\n", pod.Namespace, pod.Name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@akalenyu akalenyu mentioned this pull request Apr 30, 2023
Merged
akalenyu
akalenyu reviewed Apr 30, 2023
View reviewed changes
tests/import_test.go
pv.Spec.ClaimRef.ResourceVersion = ""
pv.Spec.ClaimRef.UID = ""
_, err = f.K8sClient.CoreV1().PersistentVolumes().Update(context.TODO(), pv, metav1.UpdateOptions{})
Expect(err).ToNot(HaveOccurred())
Copy link
Collaborator

@akalenyu akalenyu Apr 30, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expecting inside an eventually block may fail the test earlier than we want to
to get around this you can do this:

containerized-data-importer/tests/operator_test.go

Lines 99 to 106 in e6d2286

Eventually(func(g Gomega) {
cdiCrd, err = f.ExtClient.ApiextensionsV1().CustomResourceDefinitions().Get(context.TODO(), "cdis.cdi.kubevirt.io", metav1.GetOptions{})
g.Expect(err).ToNot(HaveOccurred())
for _, ver := range cdiCrd.Spec.Versions {
g.Expect(ver.Name).Should(Equal("v1beta1"))
g.Expect(ver.Storage).Should(BeTrue())
}
}, 1*time.Minute, 2*time.Second).Should(Succeed())

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I didn't change that particular thing, I just cleaned up the return value a bit so it is easier to see what actually failed. This expect if it return false it is because the update failed. Which should fail the test right there.

@awels
Copy link
Member Author

awels commented May 1, 2023

/retest-required

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2023
@kubevirt-bot
Copy link
Contributor

@awels: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels awels closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalenyu akalenyu akalenyu left review comments

@maya-r maya-r Awaiting requested review from maya-r

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@mhenriks mhenriks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awels @mhenriks @kubevirt-bot @akalenyu