Add a webhook for import and upload populator CRs #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
alromeros
force-pushed
the
populators-webhook
branch
2 times, most recently
from
40fc6ae
to
8aeebf3
Compare
This commit implements a new webhook to validate the creation and update of volumeimportsources and volumeuploadsources. It also adds proper testing for the new webhook. Signed-off-by: Alvaro Romero <alromero@redhat.com>
alromeros
force-pushed
the
populators-webhook
branch
from
8aeebf3
to
675c5cf
Compare
|
/retest-required |
mhenriks
reviewed
May 9, 2023
| return nil, err | ||
| } | ||
|
|
||
| // Reject spec updates |
There was a problem hiding this comment.
We may allow this eventually, but this is good for now
Signed-off-by: Alvaro Romero <alromero@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This Pull Request implements a new webhook to validate the creation and update of
volumeimportsourcesandvolumeuploadsources.Special notes for your reviewer:
Release note: