Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Data volume using CDI populators #2722

Merged

Commits on Jun 11, 2023

  1. move cleanup out of dv deletion

    It seemed off to call cleanup in the prepare function
    just because we don't call cleanup unless the dv is deleting.
    Instead we check in the clenup function itself if it should be
    done: in this 2 specific cases in case of deletion and in case
    the dv succeeded.
    The cleanup will be used in future commit also for population cleanup
    which we also want to happen not only on deletion.
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5689e10 View commit details
    Browse the repository at this point in the history
  2. Use populator if csi storage class exists

    Add new datavolume phase PendingPopulation to
    indicate wffc when using populators, this new
    phase will be used in kubevirt in order to know
    that there is no need for dummy pod to pass wffc phase
    and that the population will occur once creating the vm.
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1b43c6d View commit details
    Browse the repository at this point in the history
  3. Update population targetPVC with pvc prime annotations

    The annotations will be used to update dv that uses the
    populators.
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    c65dcc8 View commit details
    Browse the repository at this point in the history
  4. Adjust UT with new behavior

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    64851a9 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. updates after review

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    d537bbe View commit details
    Browse the repository at this point in the history
  2. Fix import populator report progress

    The import pod should be taken from pvcprime
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    8de69d9 View commit details
    Browse the repository at this point in the history
  3. Prevent requeue upload dv when failing to find progress report pod

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2df98bc View commit details
    Browse the repository at this point in the history
  4. Remove size inflation in populators

    The populators are handling existing PVCs.
    The PVC already has a defined requested size,
    inflating the PVC' with fsoverhead will only be
    on the PVC' spec and will not reflect on the target
    PVC, this seems undesired.
    Instead if the populators is using by PVC that the
    datavolume controller created the inflation will happen
    there if needed.
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4dd5b26 View commit details
    Browse the repository at this point in the history
  5. Adjust functional tests to handle dvs using populators

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    dfb3fd8 View commit details
    Browse the repository at this point in the history
  6. Fix clone test

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a3aac62 View commit details
    Browse the repository at this point in the history
  7. add shouldUpdateProgress variable to know if need to update progress

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1ae48ef View commit details
    Browse the repository at this point in the history
  8. Change update of annotation from denied list to allowed list

    Instead if checking if the annotation on pvcPrime is not desired
    go over desired list and if the annotation exists add it.
    
    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6690f5e View commit details
    Browse the repository at this point in the history
  9. fix removing annotations from pv when rebinding

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    5beb9b8 View commit details
    Browse the repository at this point in the history
  10. More fixes and UT

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    beeff5a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. a bit more updates and UTs

    Signed-off-by: Shelly Kagan <skagan@redhat.com>
    ShellyKa13 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8e0ad95 View commit details
    Browse the repository at this point in the history