Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add PendingPopulation DataVolume phase #2729

Merged
merged 2 commits into from
May 26, 2023
Merged

add PendingPopulation DataVolume phase #2729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17d88a7
add PendingPopulation DataVolume phase
mhenriks May 25, 2023
205f884
add IsSucceededOrPendingPopulation helper to replace a call to IsPopu…
mhenriks May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions staging/src/kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,9 @@ const (

// WaitForFirstConsumer represents a data volume with a current phase of WaitForFirstConsumer
WaitForFirstConsumer DataVolumePhase = "WaitForFirstConsumer"
// PendingPopulation represents a data volume which should be populated by
// the CDI populators but havn't created the pvc' yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: havn't. Since we want to merge this as soon as possible I guess it can be fixed in the next related PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I get for copying Shelly's code!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't get me started on your 'native English speaker' PR typos ;)

PendingPopulation DataVolumePhase = "PendingPopulation"

// Succeeded represents a DataVolumePhase of Succeeded
Succeeded DataVolumePhase = "Succeeded"
Expand Down